-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable namespace for a pluginconfig release #98
Conversation
77a2b63
to
e312637
Compare
That post-#112 rebase was slightly painful |
rebased & force-pushed |
b08edfd
to
9d67f43
Compare
squashed history after triple rebase was required |
9d67f43
to
acf88ba
Compare
Getting |
acf88ba
to
fb504f1
Compare
rebased again to incorporate ci fix |
fb504f1
to
3a559c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some mentions of plugin.Namespace
in calls to clientutil.NewRestClientGetterFromRestConfig(..)
and helm.ExportNewHelmAction(..)
Could you adapt these to use plugin.ReleaseNamespace
as well. This is to avoid unwanted side-effects if in the future the ReleaseNamespace on the test resources is changed.
Sure. I'll double check |
Closes #50.