Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable namespace for a pluginconfig release #98

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

auhlig
Copy link
Member

@auhlig auhlig commented Apr 5, 2024

Closes #50.

@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts labels Apr 5, 2024
pkg/helm/helm.go Show resolved Hide resolved
@auhlig auhlig force-pushed the feat/pluginconfig-configurable-namespace branch from 77a2b63 to e312637 Compare April 8, 2024 15:29
@auhlig
Copy link
Member Author

auhlig commented Apr 8, 2024

That post-#112 rebase was slightly painful

@auhlig auhlig requested a review from a team as a code owner April 10, 2024 10:12
@auhlig
Copy link
Member Author

auhlig commented Apr 10, 2024

rebased & force-pushed

@auhlig auhlig force-pushed the feat/pluginconfig-configurable-namespace branch from b08edfd to 9d67f43 Compare April 10, 2024 10:27
@auhlig
Copy link
Member Author

auhlig commented Apr 10, 2024

squashed history after triple rebase was required

@auhlig auhlig force-pushed the feat/pluginconfig-configurable-namespace branch from 9d67f43 to acf88ba Compare April 10, 2024 10:28
@auhlig
Copy link
Member Author

auhlig commented Apr 10, 2024

Getting the input device is not a TTY in the license check.

@auhlig auhlig force-pushed the feat/pluginconfig-configurable-namespace branch from acf88ba to fb504f1 Compare April 10, 2024 10:42
@auhlig
Copy link
Member Author

auhlig commented Apr 10, 2024

rebased again to incorporate ci fix

@auhlig auhlig force-pushed the feat/pluginconfig-configurable-namespace branch from fb504f1 to 3a559c6 Compare April 10, 2024 14:46
@auhlig auhlig requested a review from IvoGoman April 12, 2024 09:24
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some mentions of plugin.Namespace in calls to clientutil.NewRestClientGetterFromRestConfig(..) and helm.ExportNewHelmAction(..)
Could you adapt these to use plugin.ReleaseNamespace as well. This is to avoid unwanted side-effects if in the future the ReleaseNamespace on the test resources is changed.

@auhlig
Copy link
Member Author

auhlig commented Apr 15, 2024

There are some mentions of plugin.Namespace in calls to clientutil.NewRestClientGetterFromRestConfig(..) and helm.ExportNewHelmAction(..)
Could you adapt these to use plugin.ReleaseNamespace as well. This is to avoid unwanted side-effects if in the future the ReleaseNamespace on the test resources is changed.

Sure. I'll double check
Some plugin.Namespace references are to remain though, e.g. when resolving option values from a secret next to the plugin we need the plugin namespace, not the release namespace in the remote cluster, etc.

@IvoGoman IvoGoman self-requested a review April 15, 2024 10:21
@auhlig auhlig merged commit 31c32d0 into main Apr 15, 2024
7 checks passed
@auhlig auhlig deleted the feat/pluginconfig-configurable-namespace branch April 15, 2024 10:28
@auhlig auhlig restored the feat/pluginconfig-configurable-namespace branch April 15, 2024 10:28
@auhlig auhlig deleted the feat/pluginconfig-configurable-namespace branch April 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Make PluginConfig namespace configurable
2 participants