Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(greenhousectl): setup greenhouse dashboard #845

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Jan 14, 2025

Description

This PR addresses the dashboard setup in issue #685

  • Simplifies dev CLI to use only configuration files and removes all individual commands
  • Refactors make commands
    • make setup (one command to deploy controllers, webhook, dashboard, cors-proxy, onboarding the remote cluster in a demo organization)
    • PLUGIN_DIR=<abs-path-to-plugins-dir> make setup will enable testing plugins locally
    • make setup-controller-dev for minimal setup for controller development
    • make setup-webhook-dev for minimal setup for webhook development
    • make setup-dashboard for running the greenhouse dashboard locally
    • updated dev CLI docs

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan self-assigned this Jan 14, 2025
@abhijith-darshan abhijith-darshan marked this pull request as ready for review January 14, 2025 21:28
@abhijith-darshan abhijith-darshan requested review from a team as code owners January 14, 2025 21:28
@abhijith-darshan
Copy link
Contributor Author

needs cloudoperators/greenhouse-extensions#579 to be merged first

Copy link
Contributor

@uwe-mayer uwe-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯 for taking the effort creating this machine!!

I would still like to make it (even more) easy to consume. Some comments (only on the Readme, did not look into implementation). Let's iterate on this and have the target audience in mind:
People might not natively know their way around k8s, KinD and sorts.
Think

  • UI developers needing a backend,
  • interested parties wanting to take Greenhouse for a spin locally
  • domain experts wanting to wrap their application into a Plugin
  • etc.

dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Outdated Show resolved Hide resolved
dev-env/localenv/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - One command for running localenv environment
2 participants