Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pluginpresets): deletion protection for plugin preset #809

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gciezkowski-acc
Copy link
Contributor

Description

I implemented validation in the webhook to prevent the deletion of plugin presets when the greenhouse.sap/prevent-deletion annotation is present.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@gciezkowski-acc gciezkowski-acc requested a review from a team as a code owner December 17, 2024 15:13
@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts labels Dec 17, 2024
@gciezkowski-acc gciezkowski-acc changed the title feat(pluginpresets) deletion protection for plugin preset feat(pluginpresets): deletion protection for plugin preset Dec 17, 2024
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated commits from the PR. There are missing requirements from #804 will they be provided on separate PRs?

@gciezkowski-acc gciezkowski-acc force-pushed the feat/804_deletion_protection_for_plugin_preset branch 3 times, most recently from 3cbf942 to 40d15c1 Compare December 18, 2024 12:53
@gciezkowski-acc
Copy link
Contributor Author

Please remove the unrelated commits from the PR. There are missing requirements from #804 will they be provided on separate PRs?

Fixed

@gciezkowski-acc gciezkowski-acc force-pushed the feat/804_deletion_protection_for_plugin_preset branch from 40d15c1 to 44ea878 Compare December 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants