generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(charts): reduce required values & add install docs #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
kengou
previously approved these changes
Dec 16, 2024
IvoGoman
force-pushed
the
docs/install
branch
from
December 17, 2024 14:10
f228891
to
09e7485
Compare
github-actions
bot
added
documentation
Improvements or additions to documentation
idproxy
helm-charts
dependencies
labels
Dec 17, 2024
IvoGoman
changed the title
feat(charts): reduce required values & install docs
feat(charts): reduce required values & add install docs
Dec 17, 2024
IvoGoman
force-pushed
the
docs/install
branch
from
December 17, 2024 15:24
ff58e95
to
d31070c
Compare
- hard-code subdomain for auth, api and dashboard URLs - move dnsDomain, oidc to global values
- remove deprecated connectors template & values - template auth hostname from dnsDomain - default "*" corsAllowedOrigins - 2 replicas by default - enable ingress by default
- default to 2 replicas - template api hostname from global.dnsDomain
PluginDefinitions need to be manually added to the Greenhouse cluster before the Plugins can be deployed
the greenhouse OAuth2Client is automatically created, once the greenhouse organization is created
first installation of the chart requires to disable them afterwards they can be enabled again
IvoGoman
force-pushed
the
docs/install
branch
from
December 17, 2024 15:49
d31070c
to
4181891
Compare
kengou
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the required values for installing Greenhouse. Where possible URLs that use the same TLD, are templated.
It also adds instructions on the required steps to install Greenhouse into a Gardener Shoot cluster.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist