Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(charts): remove dedicated servicemonitors #796

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

IvoGoman
Copy link
Contributor

Description

The kube-monitoring plugin scrapes all pods by default. No need to bring our own monitors.
This will remove duplicate metrics.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

The kube-monitoring plugin scrapes all pods by default. No need to bring our own monitors
@IvoGoman IvoGoman requested a review from a team as a code owner December 10, 2024 17:22
@IvoGoman IvoGoman changed the title refac(charts): remove dedicated servicemonitors refactor(charts): remove dedicated servicemonitors Dec 10, 2024
@IvoGoman IvoGoman merged commit 86610cc into main Dec 11, 2024
11 of 12 checks passed
@IvoGoman IvoGoman deleted the refac/remove-service-monitors branch December 11, 2024 08:30
IvoGoman added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants