-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): deprecation of propagation controller #788
base: main
Are you sure you want to change the base?
feat(controller): deprecation of propagation controller #788
Conversation
7a7cf77
to
586bc88
Compare
bbe6d6f
to
9616539
Compare
9616539
to
f5d8e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for removing the resources from the remote system and the finalizer on successful deletion is missing.
The logic of removing resources from remote is here. I didn't touch it. Removing finalizer when it is success is here: I left the existing logic as it was. |
That logic only kicks in if the resource (team, cluster etc.) in the central cluster is deleted. This PR should remove all propagated resources from the remote cluster. This would require to run the deletion logic to remove the resources from the remote cluster and remove the finalizer if all of the resoruces were removed from the remote cluster. |
I remove filter from login so right now it should remove all resources from remote cluster. |
1c91145
to
2f514f6
Compare
Description
The Propagation Controller is deprecated, so right now we need only clean up and remove finalizer.
The tests have not been written so we should focus to make very carefully code review.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist