Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): migrate upload artifact to v4 #759

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

kengou
Copy link
Contributor

@kengou kengou commented Nov 19, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kengou kengou requested a review from a team as a code owner November 19, 2024 11:04
@kengou kengou changed the title fix(actions): add timestamp to e2e generated logfiles fix(actions): revert upload artifact to v3 Nov 19, 2024
@kengou kengou requested a review from a team as a code owner November 19, 2024 11:24
@abhijith-darshan abhijith-darshan changed the title fix(actions): revert upload artifact to v3 fix(actions): migrate upload artifact to v4 Nov 19, 2024
@abhijith-darshan abhijith-darshan merged commit 6a4e87a into main Nov 19, 2024
10 checks passed
@abhijith-darshan abhijith-darshan deleted the fix/no-ref/e2e-action branch November 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants