Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(organizations): prevents endless organization reconciliation loop #741

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Nov 14, 2024

Description

Until all controllers reconciling on organizations are merged we need to ensure that the rbac, service proxy and team role seeder controllers do not set any conditions on Organization resource.

Currently only organization_controller handles conditions and we pass the status calculation to lifecycle.Reconcile and not do it in defer func of the controller

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abhijith-darshan abhijith-darshan marked this pull request as ready for review November 14, 2024 13:54
@abhijith-darshan abhijith-darshan requested a review from a team as a code owner November 14, 2024 13:54
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 14, 2024
@abhijith-darshan abhijith-darshan changed the title fix(organizations): prevent endless organization reconciliation loop fix(organizations): prevents endless organization reconciliation loop Nov 14, 2024
@abhijith-darshan abhijith-darshan merged commit c97d2a4 into main Nov 14, 2024
3 checks passed
@abhijith-darshan abhijith-darshan deleted the fix/org_reconciliation branch November 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants