fix(organizations): prevents endless organization reconciliation loop #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until all controllers reconciling on organizations are merged we need to ensure that the rbac, service proxy and team role seeder controllers do not set any conditions on
Organization
resource.Currently only
organization_controller
handles conditions and we pass the status calculation tolifecycle.Reconcile
and not do it in defer func of the controllerWhat type of PR is this? (check all applicable)
Added tests?
Added to documentation?
Checklist