Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): set pending releases to failed #696

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IvoGoman
Copy link
Contributor

@IvoGoman IvoGoman commented Nov 5, 2024

Description

until now helm releases stuck in pending were not touched. with this fix a helm release stuck in pending is set to failed. the controller will then rollback and retry the upgrade in the next reconciliation.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

until now helm releases stuck in pending were not touched
with this fix a helm release stuck in pending is set to failed
the controller will then rollback and retry the upgrade
@IvoGoman IvoGoman requested a review from a team as a code owner November 5, 2024 13:11
@IvoGoman IvoGoman changed the title fix(plugin): set pending releases to failed fix(plugins): set pending releases to failed Nov 7, 2024
@IvoGoman IvoGoman marked this pull request as draft November 26, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants