Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e): e2e setup and cluster onboarding / offboarding test #683

Merged
merged 185 commits into from
Nov 13, 2024

Conversation

abhijith-darshan
Copy link
Contributor

@abhijith-darshan abhijith-darshan commented Oct 30, 2024

Description

This PR implements an E2E framework to run tests on gh-actions.

  • E2E workflow run on PR
  • Detect E2E scenarios in e2e folder and run parallely in matrix (Multiple K8s Versions X Scenario)
  • Initial version of e2e bootstrap provided in pkg/e2e
  • Implements E2E test for Cluster Onboarding / Offboarding

Miscellaneous -

  • greenhousectl dev enhanced to wait till manager deployment is ready (Condition Available)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Related Issues:

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

abhijith-darshan and others added 30 commits October 7, 2024 13:48
reconcile context stores the original resource that is being reconciled intact to patch status at a later point in time.
helper methods to add, remove finalizers to check and set status conditions
common reconcile interface to standardize reconciliation for all greenhouse controllers
Cluster controller implements status conditions passed to lifecycle as a statusFunc type lifecycle.Conditioner
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/ci-e2e-test.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-e2e-test.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-e2e-test.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@kengou kengou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci-e2e-test.yaml Outdated Show resolved Hide resolved
e2e/README.md Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
e2e/cluster/e2e_test.go Outdated Show resolved Hide resolved
e2e/cluster/e2e_test.go Outdated Show resolved Hide resolved
e2e/plugin/e2e_test.go Outdated Show resolved Hide resolved
e2e/shared/e2e.go Outdated Show resolved Hide resolved
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@abhijith-darshan abhijith-darshan merged commit a3a3068 into main Nov 13, 2024
19 checks passed
@abhijith-darshan abhijith-darshan deleted the feat/e2e_setup branch November 13, 2024 13:09
@IvoGoman IvoGoman linked an issue Nov 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - e2e test for Cluster lifecycle
3 participants