Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-proxy): well defined urls for exposed services with max 63 #678

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

uwe-mayer
Copy link
Contributor

Description

This enforces:

  • no -- in Cluster names
  • max length of 40 chars for Cluster names, so we make sure the hash of service-name+namespace fits into the exposed service subdomain.

Exposed service URLs will look like:

https://$cluster--$hash.$organisation.$basedomain, where $hash = service--$namespace

This reduces all host decomposition to only use the extracted ClusterName from the incoming request. We made sure this is welldefined and unambigous.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Remove if not applicable

Changed tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

@uwe-mayer uwe-mayer requested a review from a team as a code owner October 28, 2024 14:12
@uwe-mayer uwe-mayer linked an issue Oct 28, 2024 that may be closed by this pull request
cmd/service-proxy/instrumentation.go Outdated Show resolved Hide resolved
cmd/service-proxy/proxy.go Outdated Show resolved Hide resolved
pkg/admission/utils.go Outdated Show resolved Hide resolved
pkg/admission/utils.go Show resolved Hide resolved
pkg/admission/utils.go Outdated Show resolved Hide resolved
@richardtief
Copy link
Member

Could you please update the docs along the changes made: https://github.com/cloudoperators/greenhouse/blob/main/docs/user-guides/plugin/plugin-deployment.md#urls-for-exposed-services

@uwe-mayer uwe-mayer requested a review from a team as a code owner November 1, 2024 11:49
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 1, 2024
@uwe-mayer
Copy link
Contributor Author

Could you please update the docs along the changes made: https://github.com/cloudoperators/greenhouse/blob/main/docs/user-guides/plugin/plugin-deployment.md#urls-for-exposed-services

Updated the docs

Signed-off-by: Uwe Mayer <[email protected]>
Signed-off-by: Uwe Mayer <[email protected]>
@IvoGoman IvoGoman changed the title fix(service-proxy): Well defined urls for exposed services with max 63 fix(service-proxy): well defined urls for exposed services with max 63 Nov 6, 2024
Copy link
Member

@richardtief richardtief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IvoGoman IvoGoman merged commit 9ad5cfd into main Nov 7, 2024
11 of 13 checks passed
@IvoGoman IvoGoman deleted the 661-bug-service-proxy-err-no-upstream-found-for branch November 7, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - service-proxy err: "no upstream found for: /"
3 participants