Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(greenhousectl) cluster re-onboard updates token #658

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

kengou
Copy link
Contributor

@kengou kengou commented Oct 23, 2024

Description

greenhousectl cluster bootstrap ... now supports updating tokens for existing clusters. The same command needs to be re-executed then the token will be updated in the Secret

Changes in greenhousectl cluster bootstrap based on the received feedbacks:

  • free-access-mode Flag retired
  • bootstrap-kubeconfig is now kubeconfig
    • --kubeconfig is expected to point to the cluster which will be onboarded. This parameter does not need to be set. if KUBECONFIG env var is set that will be used
  • NEW FLAG--greenhouse-kubeconfig needs to be set, to point to your greenhouse cluster

greenhousectl cluster bootstrap only expects mandatory parameters: org, greenhouse-kubeconfig

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kengou kengou requested a review from a team as a code owner October 23, 2024 21:40
pkg/cmd/cluster_bootstrap.go Outdated Show resolved Hide resolved
pkg/cmd/cluster_bootstrap.go Show resolved Hide resolved
@kengou kengou requested a review from IvoGoman October 28, 2024 08:31
@kengou kengou merged commit 5885109 into main Oct 28, 2024
10 checks passed
@kengou kengou deleted the feat/greenhousectl branch October 28, 2024 10:20
@IvoGoman IvoGoman linked an issue Oct 29, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] - Refresh the Token for Clusters with greenhousectl
2 participants