Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JoinURL field to Team Spec #636

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Oct 10, 2024

Description

This PR adds JoinURL field to the Spec of Team CRD. The JoinURL field is intended for URL used to join the Team IdP group.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

I've added tests for Team validation webhook to check for creation and update of teams with various values as JoinURL.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 linked an issue Oct 10, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts labels Oct 10, 2024
@Zaggy21 Zaggy21 marked this pull request as ready for review October 17, 2024 21:18
@Zaggy21 Zaggy21 requested a review from a team as a code owner October 17, 2024 21:18
@IvoGoman IvoGoman merged commit 1ba5c64 into main Oct 25, 2024
@IvoGoman IvoGoman deleted the feat/add-joinurl-to-a-team branch October 25, 2024 12:52
IvoGoman added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Add JoinURL to a Team
2 participants