fix(audit-logs): Redact secret data #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uwe-mayer - for ginkgo logging we can pass these parameters to go test - |
|
As discussed in Slack we will completely remove |
IvoGoman
approved these changes
Aug 30, 2024
andypf
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix(audit-logs): Redact secret data * Fix linting * Remove Object and OldObject completely from log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This redacts secret data in admission request logging
Related Tickets & Documents
Added tests?
No direct way to test controller output logs with Ginkgo. Ginkgo swallows logs when testing.