Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] - Deletion Protection for PluginPresets #804

Closed
4 tasks
IvoGoman opened this issue Dec 16, 2024 · 0 comments · Fixed by #809
Closed
4 tasks

[FEAT] - Deletion Protection for PluginPresets #804

IvoGoman opened this issue Dec 16, 2024 · 0 comments · Fixed by #809
Assignees
@gciezkowski-acc
Labels
feature

Comments

@IvoGoman
Copy link
Contributor

Priority

(Medium) I'm annoyed but I'll live

User Story

As an Org Admin I would like to have additional protection on the PluginPreset resources, so that they cannot be easily deleted by accident.

Description

The PluginPreset can create Plugins for a multitude of clusters. When the PluginPreset is deleted, also all of these Plugins are removed. This can break/ remove a lot of Helm Releases.
In order to protect from this, the PluginPreset's should get an additional annotation that prevents a deletion to succeed. (greenhouse.sap/prevent-deletion).
The webhook needs to ensure that deletion requests for PluginPresets with this annotation are rejected with an appropriate error message.
This annotation should be set on every PluginPreset, whenever it is created.

Acceptance Criteria

  • Webhook ensures greenhouse.sap/prevent-deletion during PluginPreset Create admission
  • Webhook ensures deletion is blocked in case the annotation is set
  • Documentation of PluginPreset contains a section on how to delete a PluginPreset
  • Tests to verify the added behavior

Reference Issues

No response
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Dec 16, 2024
gciezkowski-acc added a commit that referenced this issue Dec 17, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
ea2d5b1 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 17, 2024
@gciezkowski-acc
feat(pluginpreset) Add unit tests to delete validator for Plugin Pres…
71daca1 
…et (#804)
@IvoGoman IvoGoman mentioned this issue Dec 18, 2024
Merged
24 tasks
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
add68c3 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpreset) Add unit tests to delete validator for Plugin Pres…
5d98a6b 
…et (#804)
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
e7531f1 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
3cbf942 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
3f2fc5a 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 18, 2024
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
40d15c1 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
2421fbd 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
44ea878 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
0e462f7 
…#804)
gciezkowski-acc added a commit that referenced this issue Dec 19, 2024
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
c7bb8e6
gciezkowski-acc added a commit that referenced this issue Dec 20, 2024
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
ca23c19 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 20, 2024
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
314515c 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Dec 20, 2024
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
101fb31 
…#804)
gciezkowski-acc added a commit that referenced this issue Dec 20, 2024
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
04de769
@uwe-mayer uwe-mayer moved this from Sprint Backlog to In progress in Greenhouse Core Roadmap Jan 7, 2025
@uwe-mayer uwe-mayer linked a pull request Jan 8, 2025 that will close this issue
feat(pluginpresets): deletion protection for plugin preset #809
Merged
24 tasks
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
7a1e9b8 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
d30fcb3 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
ff0ad99 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
3ca083c
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
a4fa7c3 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
6a22110 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
9872ebb 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
5e53ef6
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
9d814ab 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
0cd751d 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
fe2f9d4 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
41823cd
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
85c8d11 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
49a0049 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
5d862b5 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 8, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
28db2d8
gciezkowski-acc added a commit that referenced this issue Jan 9, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
ad71db1 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 9, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
932f18d 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 9, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
fbc3da6 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 9, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
499d61f
gciezkowski-acc added a commit that referenced this issue Jan 10, 2025
@gciezkowski-acc
feat(pluginpresets) Avoid plugin preset deletion when prevent deletio…
7321162 
…n annotation is set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 10, 2025
@gciezkowski-acc
feat(pluginpresets) Add unit tests to delete validator for Plugin Pre…
de8ac2c 
…set (#804)
gciezkowski-acc added a commit that referenced this issue Jan 10, 2025
@gciezkowski-acc
feat(pluginpresets) Add deletion prevention on plugin preset creation (…
8b23363 
…#804)
gciezkowski-acc added a commit that referenced this issue Jan 10, 2025
@gciezkowski-acc
feat(pluginpresets) Update documentation (#804)
6ff5b75
gciezkowski-acc added a commit that referenced this issue Jan 10, 2025
@gciezkowski-acc
feat(pluginpresets): deletion protection for plugin preset (#809)
7146247 
* feat(pluginpresets) Avoid plugin preset deletion when prevent deletion annotation is set (#804)

* feat(pluginpresets) Add unit tests to delete validator for Plugin Preset (#804)

* feat(pluginpresets) Add deletion prevention on plugin preset creation (#804)

* feat(pluginpresets) Update documentation (#804)

* feat(pluginpresets) Documentation and log update
@github-project-automation github-project-automation bot moved this from In progress to Done in Greenhouse Core Roadmap Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gciezkowski-acc gciezkowski-acc

Labels
feature
Projects
Greenhouse Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pluginpresets): deletion protection for plugin preset cloudoperators/greenhouse
2 participants
@IvoGoman @gciezkowski-acc