Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Deletion Protection for PluginPresets #804

Open
4 tasks
IvoGoman opened this issue Dec 16, 2024 · 0 comments
Open
4 tasks

[FEAT] - Deletion Protection for PluginPresets #804

IvoGoman opened this issue Dec 16, 2024 · 0 comments
Assignees
Labels

Comments

@IvoGoman
Copy link
Contributor

Priority

(Medium) I'm annoyed but I'll live

User Story

As an Org Admin I would like to have additional protection on the PluginPreset resources, so that they cannot be easily deleted by accident.

Description

The PluginPreset can create Plugins for a multitude of clusters. When the PluginPreset is deleted, also all of these Plugins are removed. This can break/ remove a lot of Helm Releases.
In order to protect from this, the PluginPreset's should get an additional annotation that prevents a deletion to succeed. (greenhouse.sap/prevent-deletion).
The webhook needs to ensure that deletion requests for PluginPresets with this annotation are rejected with an appropriate error message.
This annotation should be set on every PluginPreset, whenever it is created.

Acceptance Criteria

  • Webhook ensures greenhouse.sap/prevent-deletion during PluginPreset Create admission
  • Webhook ensures deletion is blocked in case the annotation is set
  • Documentation of PluginPreset contains a section on how to delete a PluginPreset
  • Tests to verify the added behavior

Reference Issues

No response

@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants