feat(kube-monitoring): Add Pod service discovery #553
+104
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viennaa
reviewed
Dec 13, 2024
Comment on lines
+251
to
+254
| ## Example which selects all Pods to be monitored | ||
| ## with label "monitoredby" with values any of "example-pod-1" or "example-pod-2" | ||
| selector: | ||
| matchExpressions: [] |
There was a problem hiding this comment.
The description is a copy paste error I assume.
Either we copy the original or I would comment it out.
Suggested change
| ## Example which selects all Pods to be monitored | |
| ## with label "monitoredby" with values any of "example-pod-1" or "example-pod-2" | |
| selector: | |
| matchExpressions: [] | |
| ## Custom definition to pick up specific pods with an expression. | |
| # selector: | |
| ## matchExpressions: [] |
There was a problem hiding this comment.
This leads to a failed linting. What is the error here?
Comment on lines
+258
to
+259
| matchLabels: | ||
| greenhouse/scrape: "true" |
There was a problem hiding this comment.
Do we really want to add this label everywhere needed or put it the other way around and add some do-not-scrape style?
There was a problem hiding this comment.
I would prefer an opt-in. Otherwise, we cannot ensure that multiple pods are scraped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552