Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Perses Plugin #539

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add Perses Plugin #539

wants to merge 22 commits into from
+4,806 −5

Conversation

ibakshay
Copy link
Contributor

@ibakshay ibakshay commented Dec 9, 2024

This Pull request resolves #491

Signed-off-by: IB Akshay [email protected]

@ibakshay
chore: initial commit
e9c8de2 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay
chore(perses): add initial configuration and datasource templates
0c32125 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay
Merge branch 'main' into akshay/add-perses-plugin
2eaf01c 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay
feat(kube-monitoring): add Perses datasource configuration to plugin …
c66cac0 
…definition

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
fix(kube-monitoring): update descriptions for Thanos object storage c…
05843f7 
…onfiguration fields

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
Merge branch 'main' into akshay/add-perses-plugin
a27dee9
@ibakshay
WIP
2c940df 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay
fix(perses): update plugin definition with new documentation and icon…
5b4d09f 
… URLs, and refine sidecar configuration options

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
fix(plugin): add architecture diagram
d183386 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay
fix(perses): change datasource kind to GlobalDatasource in configmap …
7575b10 
…and modify README

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
docs(perses): update README with table of contents and improve dashbo…
a636c0d 
…ard config instructions; add plugin.yaml for perses

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
docs(perses): add beta warning to README and update links for dashboa…
f153762 
…rd creation guide

Signed-off-by: IB Akshay <[email protected]>
@ibakshay
docs(perses): add perses properties
0e49235 
Signed-off-by: IB Akshay <[email protected]>
@ibakshay ibakshay requested review from a team as code owners December 9, 2024 16:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse-extensions/charts/kube-monitoring:0.19.2 already exists in OCI registry. Please increment the chart version.

@ibakshay ibakshay marked this pull request as draft December 9, 2024 16:28
@ibakshay ibakshay added the dashboard visualisation Plutono/Perses + Dashboards label Dec 10, 2024
@ibakshay ibakshay marked this pull request as ready for review December 10, 2024 09:15
@ibakshay ibakshay requested a review from richardtief December 10, 2024 09:22
@ibakshay
chore: update licenserc to ignore perses charts and correct ConfigMap…
4594c59 
… spelling in kube-monitoring values

Signed-off-by: IB Akshay <[email protected]>
@ibakshay ibakshay requested a review from a team as a code owner December 10, 2024 09:25
viennaa
viennaa requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@viennaa viennaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the Perses Plugin, really looking forward to see it in action.

Some smaller nits inline.

kube-monitoring/charts/values.yaml Outdated Show resolved Hide resolved
perses/img/perses-arch.png Outdated Show resolved Hide resolved
perses/plugindefinition.yaml Outdated Show resolved Hide resolved
perses/plugindefinition.yaml Outdated Show resolved Hide resolved
@viennaa
Copy link
Contributor

viennaa commented Dec 10, 2024

Also, add some tests please :).

@ibakshay ibakshay self-assigned this Dec 10, 2024
@ibakshay
Copy link
Contributor Author

Also, add some tests please :).

Created a PR in upstream helm chart to add tests. perses/helm-charts#42

@ibakshay
Copy link
Contributor Author

Also, add some tests please :).

Tests are added to the upstream Perses helm repo now :)

Screenshot of the tests that are run in this PR

image

viennaa
viennaa approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@viennaa viennaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viennaa viennaa viennaa approved these changes

@richardtief richardtief Awaiting requested review from richardtief

At least 1 approving review is required to merge this pull request.

Assignees

@ibakshay ibakshay

Labels
dashboard visualisation Plutono/Perses + Dashboards
Projects
Observability Roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[perses] Create an Beta plugin
2 participants
@ibakshay @viennaa