[WIP] thanos ruler compoment #534
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trouaux
force-pushed
the
thanos-ruler-component
branch
2 times, most recently
from
709212f to
5531122
Compare
viennaa
requested changes
Nov 27, 2024
thanos/charts/templates/ruler.yaml
Outdated
| retention: {{ $.Values.ruler.retention | quote }} | ||
| {{- end }} | ||
| {{- if $.Values.rbac.create }} | ||
| serviceAccountName: {{ $.Values.serviceAccount.name }} |
There was a problem hiding this comment.
Would go with a default here:
Suggested change
| serviceAccountName: {{ $.Values.serviceAccount.name }} | |
| serviceAccountName: {{ include "release.name" . }}-ruler |
thanos/charts/templates/ruler.yaml
Outdated
| {{- if $.Values.ruler.retention }} | ||
| retention: {{ $.Values.ruler.retention | quote }} | ||
| {{- end }} | ||
| {{- if $.Values.rbac.create }} |
There was a problem hiding this comment.
I'd say this can default to true, if it is not set.
thanos/charts/templates/ruler.yaml
Outdated
|
|
||
| {{ if .Values.ruler.enabled }} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment |
There was a problem hiding this comment.
We need to have this as a statefulset. When we talked about it, I said deployment but forgot that is usually should be deployed as a sfs.
trouaux
force-pushed
the
thanos-ruler-component
branch
from
5531122 to
6d0aa6f
Compare
trouaux
force-pushed
the
thanos-ruler-component
branch
from
72b3af0 to
46903d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #351