Add Perses Plugin #539
Open
Add Perses Plugin #539
+4,806
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
…definition Signed-off-by: IB Akshay <[email protected]>
…onfiguration fields Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
… URLs, and refine sidecar configuration options Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
…and modify README Signed-off-by: IB Akshay <[email protected]>
…ard config instructions; add plugin.yaml for perses Signed-off-by: IB Akshay <[email protected]>
…rd creation guide Signed-off-by: IB Akshay <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
|
|
Signed-off-by: IB Akshay <[email protected]>
… spelling in kube-monitoring values Signed-off-by: IB Akshay <[email protected]>
viennaa
requested changes
Dec 10, 2024
|
Also, add some tests please :). |
Signed-off-by: IB Akshay <[email protected]>
Co-authored-by: Tommy Sauer <[email protected]>
Co-authored-by: Tommy Sauer <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
…initions Signed-off-by: IB Akshay <[email protected]>
Created a PR in upstream helm chart to add tests. perses/helm-charts#42 |
…on.yaml Signed-off-by: IB Akshay <[email protected]>
Tests are added to the upstream Perses helm repo now :) Screenshot of the tests that are run in this PR
|
richardtief
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Fantastic! I never thought we would get Perses in this condition in 2024. Now we have it almost ready for us to use, and I am happy to follow your efforts that you are also committed to bringing to the community! Keep up the good work!
Some small comments below
| @@ -0,0 +1,22 @@ | |||
| apiVersion: v2 | |||
| name: perses-plugin | |||
There was a problem hiding this comment.
The suffix -plugin is not required.
Suggested change
| name: perses-plugin | |
| name: perses |
Comment on lines
+5
to
+7
| commonLabels: | ||
| perses: | ||
| # Default values for perses. |
There was a problem hiding this comment.
Enter an empty dict here to indicate the expected data type.
Suggested change
| commonLabels: | |
| perses: | |
| # Default values for perses. | |
| commonLabels: {} | |
| perses: | |
| # Default values for perses. |
Comment on lines
+2
to
+20
| kind: PluginDefinition | ||
| metadata: | ||
| name: perses | ||
| spec: | ||
| version: 0.1.0 | ||
| displayName: Perses | ||
| description: "Perses is a dashboard tooling to visualize metrics and traces produced by observability tools such as Prometheus/Thanos/Jaeger" | ||
| docMarkDownUrl: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/README.md | ||
| icon: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/logo.png | ||
| helmChart: | ||
| name: perses | ||
| repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts | ||
| version: '0.7.4' | ||
| options: | ||
| - default: true | ||
| description: "Deploys a sidecar container to watch all configmaps in the cluster and filters out the ones with a label `perses.dev/resource: true`. The files defined in those configmaps are written to a folder and this folder is accessed by Perses. Changes to the configmaps are continuously monitored and reflected in Perses within 10 seconds" | ||
| name: perses.sidecar.enabled | ||
| required: true | ||
| type: bool |
There was a problem hiding this comment.
The indentation of yaml looks a bit off.
Suggested change
| kind: PluginDefinition | |
| metadata: | |
| name: perses | |
| spec: | |
| version: 0.1.0 | |
| displayName: Perses | |
| description: "Perses is a dashboard tooling to visualize metrics and traces produced by observability tools such as Prometheus/Thanos/Jaeger" | |
| docMarkDownUrl: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/README.md | |
| icon: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/logo.png | |
| helmChart: | |
| name: perses | |
| repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts | |
| version: '0.7.4' | |
| options: | |
| - default: true | |
| description: "Deploys a sidecar container to watch all configmaps in the cluster and filters out the ones with a label `perses.dev/resource: true`. The files defined in those configmaps are written to a folder and this folder is accessed by Perses. Changes to the configmaps are continuously monitored and reflected in Perses within 10 seconds" | |
| name: perses.sidecar.enabled | |
| required: true | |
| type: bool | |
| kind: PluginDefinition | |
| metadata: | |
| name: perses | |
| spec: | |
| version: 0.1.0 | |
| displayName: Perses | |
| description: "Perses is a dashboard tooling to visualize metrics and traces produced by observability tools such as Prometheus/Thanos/Jaeger" | |
| docMarkDownUrl: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/README.md | |
| icon: https://raw.githubusercontent.com/cloudoperators/greenhouse-extensions/main/perses/logo.png | |
| helmChart: | |
| name: perses | |
| repository: oci://ghcr.io/cloudoperators/greenhouse-extensions/charts | |
| version: '0.7.4' | |
| options: | |
| - default: true | |
| description: "Deploys a sidecar container to watch all configmaps in the cluster and filters out the ones with a label `perses.dev/resource: true`. The files defined in those configmaps are written to a folder and this folder is accessed by Perses. Changes to the configmaps are continuously monitored and reflected in Perses within 10 seconds" | |
| name: perses.sidecar.enabled | |
| required: true | |
| type: bool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request resolves #491
Signed-off-by: IB Akshay [email protected]