Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DiskIDTransform Rules #403

Open
wants to merge 5 commits into
base: ubuntu-noble
Choose a base branch
from
Open

add DiskIDTransform Rules #403

wants to merge 5 commits into from

Conversation

ramonskie
Copy link
Contributor

this will add the diskid transform rules needed for cloudfoundry/bosh-agent#343

jpalermo
jpalermo previously approved these changes Dec 20, 2024
View reviewed changes
@ramonskie ramonskie requested review from a team, mvach and nouseforaname and removed request for a team and nouseforaname December 21, 2024 12:35
rkoster
rkoster requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed during Working group call, could you add a bit of documentation so that further people know what the paths where that we want to match against.

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_openstack_agent_settings/assets/agent.md
Comment on lines +2 to +3
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm as you can see in the related information part.

Not sure if that line break is needed and intended

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_openstack_agent_settings/assets/agent.md
# Introduction
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Therefore, we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below

I think therefore always comes with a comma

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_google_agent_settings/assets/agent.md
Comment on lines +2 to +3
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm as you can see in the related information part.

see below

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_google_agent_settings/assets/agent.md
# Introduction
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Therefore, we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_aws_agent_settings/assets/agent.md
Comment on lines +2 to +3
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm as you can see in the related information part.

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_aws_agent_settings/assets/agent.md
# Introduction
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Therefore, we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_alicloud_agent_settings/assets/agent.md
Comment on lines +2 to +3
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm as you can see in the related information part.

benjaminguttmann-avtq
benjaminguttmann-avtq reviewed Jan 13, 2025
View reviewed changes
stemcell_builder/stages/bosh_alicloud_agent_settings/assets/agent.md
# Introduction
The problem that we have is that the diskID provided by the IAAS does not correspond with the diskID on the vm
as you can see in the related information part.
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Therefore we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below
Therefore, we are trying to mitigate this issue by using diskIdTransformation as you can see in the example below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoehler fmoehler fmoehler approved these changes

@benjaminguttmann-avtq benjaminguttmann-avtq benjaminguttmann-avtq left review comments

@jpalermo jpalermo jpalermo left review comments

@rkoster rkoster rkoster requested changes

@mvach mvach Awaiting requested review from mvach mvach was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Status: Waiting for Changes | Open for Contribution
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramonskie @jpalermo @rkoster @benjaminguttmann-avtq @fmoehler