Move NonModuleScript out of modules.h/modules.c++ #3296
Merged
+64
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason for NonModuleScript to be included with modules.h/modules.c++.
|
The generated output of |
anonrig
approved these changes
Jan 6, 2025
jasnell
force-pushed
the
jasnell/jsg-module-cleanups
branch
from
d72b7e3 to
f2acce7
Compare
jasnell
force-pushed
the
jasnell/jsg-module-cleanups
branch
from
f2acce7 to
f652333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason for NonModuleScript to be included with
modules.h/modules.c++.
(this is just a small change in prep to the final push to finish up the new module registry implementation... not a critical bit but helpful to reduce the code that is in module.h/module.c++ and separate concerns a bit more)