Fix various RPC issues #2764
Merged
Fix various RPC issues #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could happen if someone tried to pipeline on a call that returned a primitive type. The error was reported as an internal runtime error instead of being reported to the app. Now the application will get a reasonable error thrown at it.
…osal. If an RPC returns a plain object (with no stubs and no disposer), then it should not be necessary to call its disposer on the caller side. I had explicitly accounted for this in the protocol, but forgot to handle it correctly in the code! So the callee context would be held open until the caller disposed the result. If the caller didn't do that, the callee would be held open until the caller context ended.
jasnell
approved these changes
Sep 20, 2024
This makes `assert.deepEqual()` work on RPC results, without having to delete the disposer first.
kentonv
force-pushed
the
kenton/fix-rpc-issues
branch
from
c289362 to
a0b780f
Compare
geelen
approved these changes
Sep 20, 2024
anonrig
approved these changes
Sep 20, 2024
kentonv
added a commit
that referenced
this pull request
Sep 23, 2024
kentonv
added a commit
that referenced
this pull request
Sep 23, 2024
Fix test flake in js-rpc-socket-test, introduced in #2764.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions.
First issue caused spurious Sentry errors.
Other two issues @geelen complained about.