Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node flag to ava, since we are using modules #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mosch
Copy link
Contributor

@mosch mosch commented Dec 30, 2021

This was required for me while following your guide. Maybe it's a valuable addition for others?

@mrbbot
Copy link
Contributor

mrbbot commented Dec 30, 2021

Hey! 👋 Thanks for this, that's really helpful. 🙂 I'm going to hold off merging this though, until v2 is merged into master, which should be in the next 1/2 weeks, just to make Git-stuff easier. If you want, you could change the target from master to v2, and I'll merge it now. The AVA recipe is now over here: https://github.com/cloudflare/miniflare/blob/v2/docs/src/content/testing/ava.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants