fix: erroneous error message for host validation #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmd5
force-pushed
the
fix-error-message
branch
from
9d0e7b5
to
706f60d
Compare
when crafting an ingress YAML file by hand its easy to write the following by mistake: ```yaml ingress: - hostname: https://example.com service: http://localhost:50100 - service: http_status:404 ``` `cloudflared` would report the error: `Hostname cannot contain a port` this confused me for a few minutes before i compared two configs and saw my mistake. this change introduces a check prior to port splitting to see if the hostname contains a protocol and reports a relevant error
andrewmd5
force-pushed
the
fix-error-message
branch
from
74e3d02
to
7625863
Compare
|
Hi @andrewmd5, we are happy to accept the change if you can rebase and add a unit test to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when crafting an ingress YAML file by hand its easy to write the following by mistake:
cloudflaredwould report the error:Hostname cannot contain a portthis confused me for a few minutes before i compared two configs and saw my mistake. this change introduces a check prior to port splitting to see if the hostname contains a protocol and reports a relevant error