Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Bump clean-css from 3.4.28 to 4.1.11 #343

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2019

Bumps clean-css from 3.4.28 to 4.1.11.

Changelog

Sourced from clean-css's changelog.

4.1.11 / 2018-03-06

  • Backports fixes to ReDOS vulnerabilities in validator code.

4.1.10 / 2018-03-05

  • Fixed issue #988 - edge case in dropping default animation-duration.
  • Fixed issue #989 - edge case in removing unused at rules.
  • Fixed issue #1001 - corrupted tokenizer state.
  • Fixed issue #1006 - edge case in handling invalid source maps.
  • Fixed issue #1008 - edge case in breaking up font shorthand.

4.1.9 / 2017-09-19

  • Fixed issue #971 - edge case in removing unused at rules.

4.1.8 / 2017-09-02

  • Fixed issue #959 - regression in shortening long hex values.
  • Fixed issue #960 - better explanation of efficiency stat.
  • Fixed issue #965 - edge case in parsing comment endings.
  • Fixed issue #966 - remote @imports referenced from local ones.

4.1.7 / 2017-07-14

  • Fixed issue #957 - 0% minification of width property.

4.1.6 / 2017-07-08

  • Fixed issue #887 - edge case in serializing comments.
  • Fixed issue #953 - beautify breaks attribute selectors.

4.1.5 / 2017-06-29

  • Fixed issue #945 - hex RGBA colors in IE filters.
  • Fixed issue #952 - parsing @page according to CSS3 spec.

4.1.4 / 2017-06-14

  • Fixed issue #950 - bug in removing unused @font-face rules.

4.1.3 / 2017-05-18

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 5, 2019
@siennathesane siennathesane requested a review from a team June 20, 2019 20:44
Copy link
Contributor

@siennathesane siennathesane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs second opinion.

@bengerman13
Copy link
Contributor

FWIW - I spent more time than I should've trying to address insecure dependencies here the other day, so I think this is just the tip of the iceberg

@siennathesane
Copy link
Contributor

Prolly.

@bengerman13
Copy link
Contributor

👎 This doesn't build

@siennathesane
Copy link
Contributor

This doesn't build

At some point we should add CI checks for this code base.

@bengerman13
Copy link
Contributor

This doesn't build

At some point we should add CI checks for this code base.

yeah. I'm not super worried about fixing the vulns, since it's only used at build time, but not getting stale would be nice.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/clean-css-4.1.11 branch from 2fcd91f to 0d36ed9 Compare September 9, 2019 16:15
@its-a-lisa-at-work
Copy link

nudge

@siennathesane
Copy link
Contributor

@its-a-lisa it's unlikely we're going to fix this anytime soon because it's going to require substantial effort to fix a build-time library, this isn't a vulnerability which is exposed to end users. This vulnerability only happens when the site is being built and not when it's deployed, so it's both low-risk and low priority.

// cc @pburkholder

@eddietejeda
Copy link

We can archive this repo. The 18F is working on re-implementing the design with USWDS 2.0

@siennathesane
Copy link
Contributor

Thanks @eddietejeda, archiving.

@markdboyd markdboyd changed the base branch from master to main April 17, 2023 13:33
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/clean-css-4.1.11 branch June 18, 2024 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants