Adding GovCloud, CN, and ADC support for global resources using the resourcetaggingapi for augments. #9475
+49
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdljohnson
force-pushed
the
7610-universal-augment-govcloud-support
branch
from
f469476
to
a14f8e8
Compare
…niversal_augment function.
bdljohnson
force-pushed
the
7610-universal-augment-govcloud-support
branch
from
a14f8e8
to
f67801e
Compare
kapilt
reviewed
May 3, 2024
c7n/tags.py
Outdated
| # unless the call is being made to us-east-1. For govcloud this is us-gov-west-1. | ||
| partition = utils.get_partition(self.region) | ||
| r = "" | ||
| if partition == "aws-us-gov": |
There was a problem hiding this comment.
this logic feels like it would be better in a utility function in utils.py, like get_global_region(partition) it would also help on the lack of test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7610
When running against GovCloud, CN, and ADC regions the universal_augment function for using the resourcetagging api fails due to mismatched partitions. This is due to global resources always being forced into us-east-1, instead of the correct region for the local partition, which in the case of GovCloud is us-gov-west-1.