Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemaker Data Quality, Model Quality, Model Explainability Job Definitions + Compilation, Processing Jobs #9464

Conversation

mattheidelbaugh
Copy link
Contributor

@mattheidelbaugh mattheidelbaugh commented Apr 25, 2024

Closes #9462 , #9461, #9437, #9440, #9421

@mattheidelbaugh mattheidelbaugh marked this pull request as draft April 25, 2024 16:02
@mattheidelbaugh mattheidelbaugh changed the title Sagemaker Data Quality, Model Quality, Model Explainability Job Definitions Sagemaker Data Quality, Model Quality, Model Explainability Job Definitions + Compilation, Processing Jobs Apr 25, 2024
@mattheidelbaugh mattheidelbaugh marked this pull request as ready for review April 25, 2024 17:06
{'StatusEquals': 'InProgress'}]))

def resources(self, query=None):
for q in self.queries:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block feels duplicated a lot, feels like its ripe for being extracted to a utility function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate pr though in that context.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed as #9469

Copy link
Collaborator

@PratMis PratMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@PratMis PratMis merged commit ca3ef0a into cloud-custodian:main May 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SageMaker Model Quality Job Definition resource
3 participants