Support for 202 for Post and Put actions #283
Conversation
afsalthaj
changed the title
|
This additions make sense to me. What's missing is updating the graph, tests and documentation :-) Please let me know what you plan to contribute, creating the graph is a little non-obvious and I can do that. |
|
@ordnungswidrig thanks for that. I can update the tests and documentation in next couple of days... |
|
@ordnungswidrig Added test cases. Also, I have changed a few put test cases to use |
test/test_flow.clj
Outdated
| (facts "PUT requests" | ||
| (let [r (resource :method-allowed? [:put] | ||
| (let [r (resource :method-allowed? (request-method-in :put) |
There was a problem hiding this comment.
Actually the best way would be to use :allowed-methods [:put].
There was a problem hiding this comment.
I am deleting the previous comment.. Sorry.. I get it
There was a problem hiding this comment.
Now you confused me because read the email notification including your comment first :-)
|
Besides my comment the patch looks fine! |
|
As a final step, can you squash the commits down to a single one? That will make the timeline easier to navigate in the future. |
afsalthaj
force-pushed
the
post_put_async_support
branch
from
75aec9a to
0f5fa33
Compare
|
@ordnungswidrig Shall I change the version to 0.15? Currently it is 0.14.2.. |
|
I'll do the version upgrade dance when I'm doing the release. |
|
Thanks for the contribution! |
Could this be taken up while #280 is in progress?
#It is adding support for asynchronus operations for put! and post!...
It adds post-enacted? decision point (default value as true) and put-enacted? decision point (default value as true) after post! and put! actions respectively.
This implies if post!/put! is not complete, it redirects to handle-accepted (
202 Accepted).A new? generally would imply the post! or put! is completed, to further push things to
handle-createdorrespond-with-entity. This is why an incompleted operation in progress is not passed to the nodes such aspost-redirect?ornew?.I am yet to add the test cases. Please review the position of the decision points and give some insights.