Refactor content negotiation and conditional requests implementation #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordnungswidrig
force-pushed
the
refactor-conneg-and-condreq
branch
2 times, most recently
from
4ac1786
to
b3190ef
Compare
|
@malcolmsparks any comments? |
|
Makes sense to make user extensions fit with sensible areas the user wants to specify, rather than allowing the user to subvert http semantics by overriding decision points that don't make sense. |
ordnungswidrig
force-pushed
the
refactor-conneg-and-condreq
branch
from
b3190ef
to
5fab141
Compare
The decision points that decide on the existence of the Accept-... headers have been there just because of technical reasons and did not had any practical application. In fact they cluterred the decision graph and added noise.
ordnungswidrig
force-pushed
the
refactor-conneg-and-condreq
branch
from
5fab141
to
5101835
Compare
Remove *-valid-date? and *-exists and more internal decision points which did not make sense to be customized. The decision logic has been incorporated into the implementation into the actual decision points. Removes * if-match-star * if-modified-since-exists? * if-modified-since-valid-date? * if-unmodified-since-exists? * if-unmodified-since-valid-date? * if-none-match-exists? * if-none-match-star? * if-match-exists? * if-match-star?
ordnungswidrig
force-pushed
the
refactor-conneg-and-condreq
branch
from
5101835
to
14d738d
Compare
|
Cleaned up the graph a bit, making it more compactly drawn and improved the trace view highlighting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some of the more technical decision points. These do not make much sense as an extension point for the user. The remaining internal decision points, mostly branches depending on the request method are dimmed in the graph now.
Removed decisions:
All changes are made backward compatible, except that the decisions
...-available?and those of conditional request must take into account that the header value can be absent or a special value, e.g.*inetag-matches-for-if-match.This is the new graph: