-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLJS Support #24
Draft
dazld
wants to merge
17
commits into
master
Choose a base branch
from
dan/cljs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CLJS Support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP / very draft. exploring problems presented by running the lib in cljs.
Fixes #9
Rework of #11
problem 1:
https://ask.clojure.org/index.php/10372/is-it-possible-to-get-the-value-of-cljs-var-from-clojure-macro
notes
I'm pretty sure now that the way this library works is almost impossible to replicate in CLJS. CLJS macros don't have access to metadata or var's values at compilation time. A way around it would be to do all the work which the macro does at runtime, but the only way I can see that being possible inside EQL values is via a lookup of some sort. It's annoying that there's so much divergence between the two dialects in this regard.
Will be pausing this for a bit and see if inspiration strikes for another way of doing this.