Add a callback cb_selenium #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`driver_arguments` is a list. With this patch, if `SELENIUM_DRIVER_ARGUMENTS` is unset the default value is an empty list instead of `None`.
This patch introduces 2 news parameters `cb_selenium` and `cb_selenium_kwargs`. The purpose of the selenium callback is to init the webpage like the scraper wants. In this callback you can use the webdriver to perform some actions and wait a expected page state. Refs: clemfromspace#24, clemfromspace#39
nfk
force-pushed
the
nfk/cb_selenium
branch
2 times, most recently
from
2f5d3bd
to
9989ad8
Compare
``` twisted 20.3.0 has requirement attrs>=19.2.0, but you'll have attrs 18.2.0 which is incompatible ``` This patch updates python requirements to try to fix the travis CI.
nfk
commented
Jul 22, 2020
| coverage<4.4 | ||
| pytest-cov==2.4.0 | ||
| pytest>=3.4.0 | ||
| pytest-cov>=2.4.0 | ||
| codeclimate-test-reporter==0.2.3 |
There was a problem hiding this comment.
The main issue is here, the project should move to https://github.com/codeclimate/test-reporter. The python version is deprecated. Whatever that dependencies order fixes the CI.
ohld
approved these changes
Dec 1, 2020
|
any updates on this PR? |
|
Hei, what should i do, if i want to add some feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces 2 news parameters
cb_seleniumandcb_selenium_kwargs. The purpose of the selenium callback is to init the webpage like the scraper wants. In this callback you can use the webdriver to perform some actions and wait a expected page state.