Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better proxy support for the middleware. #33

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

zhangtemplar
Copy link

More specifically, user can configure the proxy for each of their request. If the proxy is not yet used, a new driver will be created.

Qiang Zhang and others added 4 commits February 22, 2019 16:32
More specifically, user can configure the proxy for each of their request. If the proxy is not yet used, a new driver will be created.
Copy link

@amit-nath amit-nath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I tried installing your scrapy-selenium package and getting below error. Could you please help to fix it?

Traceback (most recent call last):
File "c:\users\amit\downloads\projects\mywork\lib\site-packages\twisted\internet\defer.py", line 1418, in _inlineCallbacks
result = g.send(result)
File "c:\users\amit\downloads\projects\mywork\lib\site-packages\scrapy\core\downloader\middleware.py", line 40, in process_request
% (method.self.class.name, response.class.name)
scrapy.exceptions._InvalidOutput: Middleware SeleniumMiddleware.process_request must return None, Response or Request, got WebDriver

Installed the package with -
pip install git+https://github.com/zhangtemplar/scrapy-selenium

@psdon
Copy link

psdon commented Feb 25, 2021

any news on this PR? @zhangtemplar @amit-nath

@zhangtemplar
Copy link
Author

I no longer have time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants