added custom issue manager class for detecting identifier columns #1120
+231
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
No other areas impacted. It is now possible to find a new issue_type.
Screenshots
See code snippetabove
Testing
Ran existing tests, added test_identifier_column.py with last commit.
Tested mainly types sequential and non-sequential arrays (sometimes with and without duplicates and sequences that do not start with 0)
Unaddressed Cases
Providing Non-integer and non-numeric columns. I think there will be just an general error fro the issue manager, like with other issues.
Links to Relevant Issues or Conversations
#923
#947
References
None
Reviewer Notes
None