This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Solarized theme fixes #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I clarified the commit message a little. Mostly to reword the second paragraph, which was confusing, and to call out that base00 and base0 are both close to 50% grey already. Update And one more fix because I forgot the word 'background' in the first paragraph :( |
The Solarized theme doesn't work well on light themes. (Light/dark have identical palettes, but the foreground/background colors are different and greys obviously get used differently.) This commit makes the 'solarized' theme use the foreground color instead of '250' and use the average of base00 and base0 for DiskBar. (These greys are already close to 50%.) This commit also adds two 16-color themes utilizing the extra violet/ orange colors, and uses the appropriate grey color for DiskBar.
This was referenced Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solarized theme doesn't work well on light themes. (Light/dark have
identical palettes, but the foreground/colors are different and greys
obviously get used differently.)
So the 'solarized' theme uses the foreground color instead of '250' and
uses the average of base00 and base0 for DiskBar.
This commit also adds two 16-color themes utilizing the extra
violet/orange colors, and using the appropriate grey color for DiskBar.