Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary azurerm_app_service_virtual_network_swift_connection resource #394

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jcma-google
Copy link
Contributor

@jcma-google jcma-google commented Sep 24, 2024

Description

We don't need this resource because we have the virtual_network_subnet_id set in the app resource.

Checklist

General

  • [x ] Added the correct label
  • [x ] Assigned to a specific person or civiform/deployment-system
  • [x ] Created tests which fail without the change (if possible)
  • [ x] Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)
  • [x ] Extended the README / documentation, if necessary

Instructions for manual testing

If instructions are needed for manual testing by reviewers, include them here.

Issue(s) this completes

@jcma-google jcma-google merged commit b209722 into main Sep 25, 2024
7 checks passed
@jcma-google jcma-google deleted the jcma-azure-bugfix branch September 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants