Fix vpc count for check and use list of subnet IDs #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb1701
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use new list of subnet IDs and also fix the VPC count. Tested on charlotte test environment and this doesn't change anything for existing deployments
Checklist
General
civiform/deployment-systembin/setupwithout your changes and thenbin/deploywith your changes to ensure your changes don't break existing deployments)Instructions for manual testing
Tested by deploying in the charlotte test environment with the config from this branch and tested to ensure this didn't change anything in an existing environment
Issue(s) this completes
civiform/civiform#7648