Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make load balancer internal when vpc is not managed through CiviForm #344

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

dkatzz
Copy link
Contributor

@dkatzz dkatzz commented Jul 3, 2024

Description

If we don't do this, we get an error:

│ Error: creating ELBv2 application Load Balancer (charlotte-vpc10-civiform-lb): InvalidSubnet: VPC vpc-0f18a363a62cc1675 has no internet gateway
│       status code: 400, request id: f09051a2-e2fe-4b4d-9bc5-c80ba8f2d009
│ 
│   with module.ecs_fargate_service.aws_lb.civiform_lb,
│   on ../../modules/ecs_fargate_service/[main.tf](http://main.tf/) line 26, in resource "aws_lb" "civiform_lb":
│   26: resource "aws_lb" "civiform_lb" {

This is needed for Charlotte's deployment. We could also decide to make this a separate variable from the vpc changes, or can do that in the future if they no longer should be tied together.

Checklist

General

  • Added the correct label
  • Assigned to a specific person or civiform/deployment-system
  • Performed manual testing (at a minimum run bin/setup without your changes and then bin/deploy with your changes to ensure your changes don't break existing deployments)

Instructions for manual testing

Tested by deploying in the charlotte test environment with the config from this branch and tested to ensure this didn't change anything in an existing environment

Issue(s) this completes

civiform/civiform#7648

@dkatzz dkatzz added the enhancement New feature or request label Jul 3, 2024
@dkatzz dkatzz self-assigned this Jul 3, 2024
@dkatzz dkatzz requested review from a team, yegle and rockycodes and removed request for a team and yegle July 3, 2024 20:59
@dkatzz dkatzz merged commit cae3db5 into main Jul 5, 2024
5 checks passed
@dkatzz dkatzz deleted the dkatz-internallb branch July 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants