Better gamer tag crew component fix for b3095 #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix introduced in d1b35aa didn't resolve some broken scenarios.
github-actions
bot
added
the
triage
gottfriedleibniz
approved these changes
May 22, 2024
gottfriedleibniz
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The fix introduced in d1b35aa (#2358) didn't resolve some broken scenarios. This PR is meant to resolve everything.
How is this PR achieving the goal
Reworking the original fix to cover all possible scenarios where gamer tags weren't working as intended on b3095.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 3095
Platforms: Windows
Checklist
Fixes issues