Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/profiler): add natives exposing start/stop recording #2486

Closed

Conversation

AvarianKnight
Copy link
Contributor

  • currently trying to do recordings can only be done via console commands, which can be tedious
  • this adds PROFILER_START_RECORDING and PROFILER_STOP_RECORDING to allow automating profiler captures

Goal of this PR

Allow resources to start/stop recording to allow for easier automation of testing performance of code

How is this PR achieving the goal

Exposes PROFILER_START_RECORDING and PROFILER_STOP_RECORDING

This PR applies to the following area(s)

Natives, SCRT

Successfully tested on

C#

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

- currently trying to do recordings can only be done via console commands, which can be tedious
- this adds `PROFILER_START_RECORDING` and `PROFILER_STOP_RECORDING` to allow automating profiler captures
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant