Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick edit to eval page #8753

Merged
merged 2 commits into from
May 16, 2024
Merged

Quick edit to eval page #8753

merged 2 commits into from
May 16, 2024

Conversation

BeFunes
Copy link
Contributor

@BeFunes BeFunes commented May 7, 2024

Description

A brief description of the changes.

Reasons

A link to a GitHub and/or JIRA issue (if applicable).
Otherwise, a brief sentence about why you made these changes.

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 馃樃:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@BeFunes BeFunes requested review from a team as code owners May 7, 2024 09:53
@@ -65,7 +65,7 @@ Given the volatile nature of evaluations, evaluations orchestrated by the Circle

Instead, a summary of the evaluation results is created and presented:

* As a comment on the corresponding GitHub pull request (GitHub projects only):
* As a comment on the corresponding GitHub pull request (currently available only for projects integrated with Github OAuth):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* As a comment on the corresponding GitHub pull request (currently available only for projects integrated with Github OAuth):
* As a comment on the corresponding GitHub pull request (currently available only for projects integrated with xref:github-integration#[Github OAuth]):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a suggestion so people can get some more info on what this actually means

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted!

@rosieyohannan rosieyohannan merged commit 587a4f0 into master May 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants