Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ip-ranges.adoc show deprecation of macOS IPs #8745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

labsquared
Copy link
Contributor

@labsquared labsquared commented May 2, 2024

Description

Add note to indicate deprecation of known macOS IPs.

Reasons

macOS well-known IPs are no longer supported after April 24, 2024.

Content Checklist

Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.

Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 馃樃:

  • Break up walls of text by adding paragraph breaks.
  • Consider if the content could benefit from more structure, such as lists or tables, to make it easier to consume.
  • Keep the title between 20 and 70 characters.
  • Consider whether the content would benefit from more subsections (h2-h6 headings) to make it easier to consume.
  • Check all headings h1-h6 are in sentence case (only first letter is capitalized).
  • Is there a "Next steps" section at the end of the page giving the reader a clear path to what to read next?
  • Include relevant backlinks to other CircleCI docs/pages.

@labsquared labsquared requested review from a team as code owners May 2, 2024 22:25
Copy link
Member

@kelvintaywl kelvintaywl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm sorry to request changes here, but thinking on behalf of readers/customers, I wonder if we can announce this change better?
I hope you can hear me out 馃檱

  1. Leaving the listed IP ranges around can cause confusion; I'd argue removing the listed IP ranges would be less confusing.
  2. this change would mean that the following text is still there, which can also confuse

macOS builds are automatically restricted within the IP ranges listed here. In other words, you do not have to explicitly set circleci_ip_ranges: true for macOS builds.
(ref)

If we prefer setting the on its deprecation, can we be verbose and say something like "the earlier list of IP ranges are no longer supported/guaranteed for MacOS builds".
ideally, a documented next-step / workaround would also be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants