Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hive plot to networkD3 #110

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cashoes
Copy link
Contributor

@cashoes cashoes commented Mar 18, 2016

This is a minimal working implementation of the hive plot (http://www.hiveplot.net/) largely adapted from code by Mike Bostock found here (https://gist.github.com/mbostock/2066415).

Currently maps nodes to 3 axes by identifying sources, sinks and hub or manager nodes. Node size, colour, link size and colour are mappable, though I still need to add some sanity checking code on the R side to make sure inputs make sense.

I'd appreciate a discussion around features to add or tips on the javascript side, as this is my first dive into D3.js.

@timelyportfolio
Copy link
Collaborator

I look forward to checking this out. I had built d3hiveR(blog post). Maybe we can merge the two for functionality. In this little bit of code, I sort of discuss what I was trying to accomplish.

@cashoes
Copy link
Contributor Author

cashoes commented Mar 18, 2016

My googling-skills failed me... I knew of HiveR, but wasn't aware of d3hiver (when do you sleep?!) The functionality of mine is pretty basic (I took this on partly to learn more about D3). Thank you for the blog post link... I'll take a look. Merging functionality seems the best path forwards and leveraging HiveR's existing capabilities would be smart...

@timelyportfolio
Copy link
Collaborator

@cashoes, blame it on my complete disregard for SEO :) Let me know what you find and let's make it better. I know networkD3 is particularly focused on simplicity and universality, so if we get too specific or complicated then perhaps we should target a dedicated, focused package.

@christophergandrud
Copy link
Owner

This looks interesting. @cashoes could you provide a minimally working example for the hiveNetwork documentation and testing?

@cashoes
Copy link
Contributor Author

cashoes commented Mar 28, 2016

Sure thing @christophergandrud! Any chance you could provide an example of the type of testing you have in place for existing networkD3 functions? e.g. do you write tests just on R side? Or for the JS as well?

@christophergandrud
Copy link
Owner

Currently there are just test in R that should trigger a variety of behaviours in the JS. Kind of simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants