(#2603) Export pin status #2618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
3f92a95
to
b06294b
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
b06294b
to
33c2009
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
33c2009
to
ae805d4
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
ae805d4
to
5c65aa2
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
5c65aa2
to
873033e
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
873033e
to
290ac65
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
2 times, most recently
from
0befa46
to
90132e7
Compare
TheCakeIsNaOH
force-pushed
the
export-pin
branch
2 times, most recently
from
e378b21
to
b33cdad
Compare
|
Is there any news on this? It is essential..
So |
|
@aetonsi This PR is in draft and no milestone has been targetted for its release. |
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
b33cdad
to
beab8e7
Compare
|
Rebased on top of #3003 |
This helps ensure that package IDs are handled in a case insensitive manner.
This allows overriding of remembered package parameters, install arguments, cache location and execution timeout during upgrade. So a user can pass in different package parameters or arguments without having to completely reinstall the package or turn off remembered arguments. Switch arguments cannot be checked, because the lack of a switch normally would mean that they are just relying on the remembered args to remember it, so there is no way to determine if an override of the remembered args is appropriate.
…ration This adds a new method, GetPackageConfigFromRememberedArguments which is similar to SetConfigFromRememberedArguments, but operates using a different method. First, a OptionSet is set up, so only the config that is passed in is modified, instead of the config that the global options parser was set with with. Second, it returns the modified configuration instead of the original configuration, because it is the local configuration being modified. Third, it has a more general name and changes log messages to be more general, so it later can more easily be reused for uninstall and export. This change fixes remembered arguments when Chocolatey is used as a library, like in ChocolateyGUI, where the config that is passed to the install_run method is not necessarily the same config object that was used to set up the global argument parser. The downside of using a new commandline parser is that it opens up the possibility of drift between the upgrade/global arguments and this added parser. However, this is not an issue because the format of the saved arguments is known, and any added arguments there would not work without being added here as well, which would be picked up during development.
Instead of exporting via building an xml document manually, this creates a PackagesConfigFilePackageSetting and serializes that to create the xml document that is saved. This allows for usage of the same class as is used to read in packages.config files to export those files. The reason the various "Specified" members are added to the PackagesConfigFilePackageSetting class is so if an element is not set during export, it will not show up at all in the resulting serialized packages.config file.
This adds the --include-remembered-arguments option which is used to export any remembered arguments. It reuses the GetPackageConfigFromRememberedArguments method in the NugetService to read and parse the remembered arguments.
This adds the ability for the export command to include pins in the exported file. They will be exported if --include-arguments is specified, but can be excluded with --exclude-pins.
TheCakeIsNaOH
force-pushed
the
export-pin
branch
from
beab8e7
to
d2f06e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds the ability for the export command to include pins in the
exported file. They will be exported if --include-arguments is
specified, but can be excluded with --exclude-pins.
Motivation and Context
See #2603
Testing
.\choco.exe install iperf2 wget --allow-unofficial.\choco.exe pin add -n iperf2 --allow-unofficial.\choco.exe export --include-arguments --allow-unofficialpackages.configincludes<package id="iperf2" pinPackage="true" />.\choco.exe export --include-argument --exclude-pins --allow-unofficialpackages.configdoes not includepinPackageforiperf2Change Types Made
Related Issue
Fixes #2603
Depends on #2506 (and thus #3003 as well)
Change Checklist