Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#5, #8) Move core extension to new extensions repository #9

Merged

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Mar 21, 2022

This pull request adds the chocolatey-core.extension to this repository, and updates the URLs to be pointing to the correct location here.

Additionally the aliases that was used in chocolatey-core.extension have been expanded to ensure that we don't get alias related bugs anymore.

related to #5 and fixes #8

https://app.clickup.com/t/20540031/ENGTASKS-1188
https://app.clickup.com/t/20540031/ENGTASKS-1186

Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for taking care for this!

Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost missed these, there's a couple more aliases we can clean up in the psm1 here.

@pauby pauby changed the title (#5, #8) Move core extension to new extensions repository (#5, #8) Move core extension to new extensions repository (CU-ENGTASKS-1186) Apr 6, 2022
@pauby pauby changed the title (#5, #8) Move core extension to new extensions repository (CU-ENGTASKS-1186) (#5, #8) Move core extension to new extensions repository Apr 6, 2022
@AdmiringWorm AdmiringWorm force-pushed the AdmiringWorm/issue5 branch from b2db632 to d51bccf Compare April 7, 2022 09:55
@AdmiringWorm AdmiringWorm requested review from vexx32 and gep13 April 7, 2022 09:56
Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for sorting that out! One minor question but other than that, this looks great!

This commit updates the URL's used in the metadata
for the chocolatey-core.extension package to point to
the correct repository.
This commit updates all helper scripts to expand the
aliases that are currently being used, to instead use
the concrete cmdlet instead.
This commit adds a new `update.ps1` script to update
the release notes inside the nuspec file to include the
actual changelog.
@AdmiringWorm AdmiringWorm force-pushed the AdmiringWorm/issue5 branch from d51bccf to 9395772 Compare April 7, 2022 13:24
@vexx32 vexx32 merged commit 990e08f into chocolatey-community:master Apr 8, 2022
@vexx32
Copy link
Contributor

vexx32 commented Apr 8, 2022

Thanks for adding this @AdmiringWorm! 💖

@AdmiringWorm AdmiringWorm deleted the AdmiringWorm/issue5 branch April 8, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand aliases used in chocolatey-core.extension helper scripts
3 participants