-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#5, #8) Move core extension to new extensions repository #9
(#5, #8) Move core extension to new extensions repository #9
Conversation
dedaeae
to
b2db632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for taking care for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost missed these, there's a couple more aliases we can clean up in the psm1 here.
b2db632
to
d51bccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for sorting that out! One minor question but other than that, this looks great!
src/chocolatey-core.extension/extensions/Get-AppInstallLocation.ps1
Outdated
Show resolved
Hide resolved
This commit updates the URL's used in the metadata for the chocolatey-core.extension package to point to the correct repository.
This commit updates all helper scripts to expand the aliases that are currently being used, to instead use the concrete cmdlet instead.
This commit adds a new `update.ps1` script to update the release notes inside the nuspec file to include the actual changelog.
d51bccf
to
9395772
Compare
Thanks for adding this @AdmiringWorm! 💖 |
This pull request adds the
chocolatey-core.extension
to this repository, and updates the URLs to be pointing to the correct location here.Additionally the aliases that was used in
chocolatey-core.extension
have been expanded to ensure that we don't get alias related bugs anymore.related to #5 and fixes #8
https://app.clickup.com/t/20540031/ENGTASKS-1188
https://app.clickup.com/t/20540031/ENGTASKS-1186