fix: provideSharedConfig cant deep optional

chizukicn · Oct 14, 2023 · f4958de · f4958de
1 parent 7065bf6
commit f4958de
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -29,6 +29,7 @@
   "dependencies": {
     "@vueuse/core": "^10.5.0",
     "defu": "^6.1.2",
-    "maybe-types": "^0.1.0"
+    "maybe-types": "^0.1.0",
+    "type-fest": "^4.4.0"
   }
 }
diff --git a/packages/shared/src/provides/config.ts b/packages/shared/src/provides/config.ts
@@ -1,9 +1,10 @@
 import type { InjectionKey } from "vue";
 import { inject, provide } from "vue";
 import defu from "defu";
+import type { PartialDeep } from "type-fest";
 import type { ActivateEvent } from "../types";
 
-const SHARED_CONFIG_KEY: InjectionKey<Partial<SharedConfig>> = Symbol("SharedConfig");
+const SHARED_CONFIG_KEY: InjectionKey<PartialDeep<SharedConfig>> = Symbol("SharedConfig");
 
 export interface SharedConfig {
   icon: {
@@ -21,7 +22,7 @@ export const DEFAULT_SHARED_CONFIG: SharedConfig = {
   activateEvent: "dblclick"
 };
 
-export function provideSharedConfig(config: Partial<SharedConfig>) {
+export function provideSharedConfig(config: PartialDeep<SharedConfig>) {
   provide(SHARED_CONFIG_KEY, config);
 }
 

diff --git a/playground/src/app.vue b/playground/src/app.vue
@@ -35,8 +35,7 @@ export default defineComponent(() => {
 
   provideSharedConfig({
     icon: {
-      size: 96,
-      sizeUnit: "px"
+      size: 96
     }
   });
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml