Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and generate using remote template feature #38

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ZeroX-DG
Copy link

@ZeroX-DG ZeroX-DG commented Feb 17, 2018

Hey @chiunhau ,
I have added a download template feature for p5 manager. Here is how to use it:

p5 g <project_name> -t owner/repo

or 

p5 g <project_name> -t owner/repo@develop

The first command will download files from the repo and by default it will take master branch. If you want to change the branch the second command will allow you to pick another branch (develop).

If you want to try then you can use my repo:

p5 g testProject -t ZeroX-DG/CodingTrainP5

@ZeroX-DG ZeroX-DG changed the title added download template feature Download and generate using remote template feature Feb 17, 2018
@alexdmejias
Copy link

alexdmejias commented May 18, 2018

@ZeroX-DG I just saw this, it looks like you hardcoded some github creds in your code, you might want to remove them and remove that client from your github API clients.

I also wonder how this could be extended to use other libraries other than P5, it looks like you are mostly there, if you aren't there already

@ZeroX-DG
Copy link
Author

@alexdmejias thank you for remind me to remove them 😄 I also think extending for other libraries is a great idea, but I'm not sure when I'll be able to create that feature (I'm currently working on many projects). In the meantime, you can add that feature if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants