Bump webpacker from 4.0.2 to 5.4.0 #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In versions of webpacker prior to 5.4.0, webpacker has a dependency on `node-sass`, which has a dependency on `node-gyp`. This dependency seems to be causing problems with Apple's slicon chip. In 5.4.0, this dependency is removed in favor of `sass`, which is the default implemenation written in dart. `sass` does not depend on `node-gyp`.
|
@AbuMareBear Can you copy and past the test failures you're seeing? I pulled down this branch and both |
|
I forgot to mention that I'm on an x86 Mac. |
|
Opps. All the tests are green for me too. I'm not sure why I had failures before. |
|
I'm getting some new warnings from the change to Dart SASS, but they seem to be issues with the CSS framework that have already been mentioned in its repo. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions of webpacker prior to 5.4.0, webpacker has a dependency on
node-sass, which has a dependency onnode-gyp. This dependency seemsto be causing problems with Apple's slicon chip. In 5.4.0, this
dependency is removed in favor of
sass, which is the defaultimplemenation written in dart.
sassdoes not depend onnode-gyp.Running
yarnwith version lower that 5.4.0 always fails on installnode-sasseven when updating python to python3. After upgrading I am able to runyarnand the app successfully runs. However, running the test suite results in multiple failures. These failures do not seem to be caused bywebpackerbut I am not 100% sure. Are there failing tests when using version 4?