Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Obsidian 1.x #102

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

liu-qilong
Copy link

@liu-qilong liu-qilong commented Oct 14, 2022

I have been using Yin and Yang for its minimalism and tasteful appearance for more than a year. However, Obsidian v1.0 with massive changes to the UI setting was released on October 13, 2022, which caused disorder in various old themes, including Yin and Yang. This fork aims at adapting this widely loved Obsidian theme to the current version. If you agree with the following adjustments, please consider accepting this pull request 馃馃槃

Change List

Major changes are listed below:

  • Note tabs related
    • Revise the note tab style to simple rounded rectangle.
    • Align the top-lines of the note tab and the sidebars.
  • Element style related
    • Remove the underline of external links.
    • Adjust the font size in the theme selection drop-down manual.
    • Remove relationship lines in file explorer.
    • Remove relationship lines in outline pane.
    • Remove the highlight background of the active day in the calendar plugin.
    • Remove the annoying white rectangle in the embedded box.
  • Borderlines related
    • Remove the right border of the left sidebar.
    • Remove the tab panel's bottom border.
    • Align the left-sidebar bottom in full-screen mode.
    • Search input related
      • Solve breaks of the focus prompt-input border.
      • Solve over-enlarged prompt-input.
      • Adjust prompt-input padding.
      • Aligned search icon in "search installed plugins".
      • Remove duplicate search input clear button.
  • PDF export related
    • Revise external links' colour in pdf exporting.
    • Revise block quote colour and border in pdf exporting.
    • Revise heading 1~6 sizes in pdf exporting.
  • Mobile app related
    • Adjust mobile workspace padding.
    • Adjust embedded box content padding.
    • Remove strange icon in view header bar.
    • Solve breaks of the focus prompt-input border.

Example Issues & Fixes

Issues:
i1

Fix:
f1

Issues:
i2

Fix:
f2

@liu-qilong liu-qilong changed the title Adapt to obsidian 1.0 Adapt to Obsidian 1.0 Oct 14, 2022
@turing0
Copy link

turing0 commented Oct 16, 2022

Nice, I like it!

@Samsamsam21
Copy link

Nice, thks!

@protortyp
Copy link

Awesome, thank you so much! I'm using this theme every day 馃コ

@f3ss1
Copy link

f3ss1 commented Oct 23, 2022

IDK really is it my problem or you forgot to fix it though :)

image

That is how the close/minimize/restore down look for me in the upper right. Any ideas on this? :)

Had the same problem with the original one once 1.0 released, same with yours update. This theme only, others work ok-ish.

@liu-qilong liu-qilong changed the title Adapt to Obsidian 1.0 Adapt to Obsidian v1.x Dec 24, 2022
@liu-qilong liu-qilong changed the title Adapt to Obsidian v1.x Adapt to Obsidian 1.x Dec 24, 2022
@liu-qilong
Copy link
Author

IDK really is it my problem or you forgot to fix it though :)

image

That is how the close/minimize/restore down look for me in the upper right. Any ideas on this? :)

Had the same problem with the original one once 1.0 released, same with yours update. This theme only, others work ok-ish.

Thanks for your feedback. Recently I tested it on a Windows 11 machine and refined the title buttons as below:

  • Refined the shape of the title buttons' backgrounds to rectangles.
  • All backgrounds are transparent when the mouse doesn't hover over them.

Pasted image 20221224115735

  • When hovering over the close button, the background is highlighted as red.

Pasted image 20221224115831

Hoping that this can solve the issue.

This was referenced Dec 24, 2022
@425833137
Copy link

There is still some problems. My obsidian version is 1.1.9
image
But it is much better than before馃槀馃憦馃徎Thank you for your working!

@425833137
Copy link

There is still some problems. My obsidian version is 1.1.9 image But it is much better than before馃槀馃憦馃徎Thank you for your working!

and left sidebar as well
image

@liu-qilong
Copy link
Author

liu-qilong commented Jan 19, 2023

There is still some problems. My obsidian version is 1.1.9 image But it is much better than before馃槀馃憦馃徎Thank you for your working!

and left sidebar as well image

Thanks for your feedback! I usually use the dark mode so I didn't notice this issue before. It should have been fixed now. Please feel free to contact me if there is still something I neglect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants