Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving prop-types to dependencies #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moving prop-types to dependencies #154

wants to merge 1 commit into from

Commits on Jan 19, 2023

  1. Moving prop-types to dependencies 

    Although prop-types is meant to run only on development environments, it still is a package required in production code.

Having prop-types under devDependencies means that whoever wants to use react-lottie will get a module not found error for it.
Also the recomendation from prop-types team is to add their package as dependencies not devDependencies. You can see this on "How to Depend on This Package?" section on their npm page https://www.npmjs.com/package/prop-types
    @victormf2
    victormf2 committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    7298d36 View commit details
    Browse the repository at this point in the history