Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make prop-types a regular dependency #138

Closed

Conversation

matt-koevort
Copy link

@matt-koevort matt-koevort commented Jan 26, 2022

Since the package isn't bundled, just transpiled, prop-types is making it into the final dist. This is causing issues in production as prop-types is not present due to it being a dev dependency on the package. Hoping that making it a regular dependency will solve the problem in the meantime.

@jackall3n
Copy link

I've created a fork and a new package for this project as it seems dead. I've added this change to it:

https://www.npmjs.com/package/lottie-jsx
https://github.com/jackall3n/react-lottie/blob/master/CHANGELOG.md#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants